rmdmattingly commented on code in PR #7282:
URL: https://github.com/apache/hbase/pull/7282#discussion_r2326002588
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java:
##########
@@ -353,39 +305,39 @@ public synchronized boolean triggerNow() {
return super.triggerNow();
}
+ /**
+ * Chore runs completely reset the state of the QuotaCache. This means
that users get their full
+ * usage allotment back, since we throw away the accounting that was
tracking their progress
+ * toward their limits. For this reason, it's recommended that chore runs
should be infrequent.
+ */
Review Comment:
For us this is probably okay because we use per-second quotas, so the
accounting loss isn't so significant, but it does seem like a big limitation
for quotas with larger time units (which we do technically support, no idea how
widely they're used). Anything we can do to maintain the usage accounting?
If it won't be easy, it could be worth an email to the dev list to see if
anyone objects to this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
