virajjasani commented on code in PR #7242:
URL: https://github.com/apache/hbase/pull/7242#discussion_r2320825808
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/metrics/ServerSideScanMetrics.java:
##########
@@ -77,6 +79,8 @@ protected AtomicLong createCounter(String counterName) {
"BYTES_READ_FROM_BLOCK_CACHE";
public static final String BYTES_READ_FROM_MEMSTORE_METRIC_NAME =
"BYTES_READ_FROM_MEMSTORE";
public static final String BLOCK_READ_OPS_COUNT_METRIC_NAME =
"BLOCK_READ_OPS_COUNT";
+ public static final String RPC_SCAN_TIME_METRIC_NAME = "RPC_SCAN_TIME";
+ public static final String RPC_QUEUE_WAIT_TIME_METRIC_NAME =
"RPC_QUEUE_WAIT_TIME";
Review Comment:
All of them are scan metrics so it is fine, but if we use `RPC_SCAN_TIME`,
probably we could also use `RPC_SCAN_QUEUE_WAIT_TIME`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
