Apache9 commented on code in PR #7231:
URL: https://github.com/apache/hbase/pull/7231#discussion_r2302899347
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -5829,7 +5829,7 @@ private long replayRecoveredEdits(final Path edits,
Map<byte[], Long> maxSeqIdIn
}
} catch (EOFException eof) {
if (!conf.getBoolean(RECOVERED_EDITS_IGNORE_EOF, false)) {
- Path p = WALSplitUtil.moveAsideBadEditsFile(walFS, edits);
+ Path p = WALSplitUtil.moveAsideBadEditsFile(getWalFileSystem(),
edits);
Review Comment:
It should be a bug of the old code. In WALSplitUtil.moveAsideBadEditsFile,
we use fs.rename, which means source and target must be on the same file system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
