PDavid commented on code in PR #7236:
URL: https://github.com/apache/hbase/pull/7236#discussion_r2300514695
##########
hbase-server/src/main/resources/hbase-webapps/master/table.jsp:
##########
@@ -170,6 +170,26 @@
<% return;
} %>
+<%
+ // handle the case for fqtn is not null with IllegalArgumentException
message + redirect
+ try {
+ TableName tn = TableName.valueOf(fqtn);
+ TableName.isLegalNamespaceName(tn.getNamespace());
+ TableName.isLegalTableQualifierName(tn.getQualifier());
+ } catch (IllegalArgumentException e) {
+%>
+ <div class="container-fluid content">
+ <div class="row inner_header">
+ <div class="page-header">
+ <h1>Table not legal</h1>
+ </div>
+ </div>
+ <p><hr><p>
+ <jsp:include page="redirect.jsp" />
+ </div>
+<% return;
+ } %>
Review Comment:
This is super-minor:
I just saw that there is a "blank" check in the PR build and it says:
> The patch has 1 line(s) that end in blanks.
See:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7236/2/artifact/yetus-general-check/output/blanks-eol.txt
It marks this row. Can @wangxiangdong123 can you please remove the
whitespaces at the end of this line?
```suggestion
} %>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
