stoty commented on code in PR #6456:
URL: https://github.com/apache/hbase/pull/6456#discussion_r2297162659
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java:
##########
@@ -307,9 +307,15 @@ Comparator.<Path, Long> comparing(p ->
AbstractFSWALProvider.getTimestamp(p.getN
* @return the relative WAL directory name, e.g.
<code>.logs/1.example.org,60030,12345</code> if
* <code>serverName</code> passed is
<code>1.example.org,60030,12345</code>
*/
- public static String getWALDirectoryName(final String serverName) {
+ public static String getWALDirectoryName(String serverName) {
+ String address =
Review Comment:
This logic is repeated sevaral times.
Could be consolidated into a method ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
