chandrasekhar-188k commented on code in PR #7126:
URL: https://github.com/apache/hbase/pull/7126#discussion_r2234000332
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/monitor/ExcludeDatanodeManager.java:
##########
@@ -95,7 +96,31 @@ public StreamSlowMonitor getStreamSlowMonitor(String name) {
return streamSlowMonitors.computeIfAbsent(key, k -> new
StreamSlowMonitor(conf, key, this));
}
- public Map<DatanodeInfo, Long> getExcludeDNs() {
+ /**
+ * Enumerates the reasons for excluding a datanode from certain operations.
Each enum constant
+ * represents a specific cause leading to exclusion.
+ */
+ public enum ExcludeCause {
+ CONNECT_ERROR("connect error"),
+ SLOW_PACKET_ACK("slow packet ack");
Review Comment:
I think a DN is excluded if the disk size of that Node exceeds the
configured threshold (90% default)
are we planning to address all the possible scenarios of DN exclusion here
or specific ones?
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/monitor/ExcludeDatanodeManager.java:
##########
@@ -95,7 +96,31 @@ public StreamSlowMonitor getStreamSlowMonitor(String name) {
return streamSlowMonitors.computeIfAbsent(key, k -> new
StreamSlowMonitor(conf, key, this));
}
- public Map<DatanodeInfo, Long> getExcludeDNs() {
+ /**
+ * Enumerates the reasons for excluding a datanode from certain operations.
Each enum constant
+ * represents a specific cause leading to exclusion.
+ */
+ public enum ExcludeCause {
+ CONNECT_ERROR("connect error"),
+ SLOW_PACKET_ACK("slow packet ack");
Review Comment:
this exclusion is done at name node itself, so not applicable at RS side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
