pankaj72981 commented on code in PR #6456:
URL: https://github.com/apache/hbase/pull/6456#discussion_r2284409010
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java:
##########
@@ -321,9 +325,13 @@ public static String getWALDirectoryName(final String
serverName) {
* @param serverName Server name formatted as described in {@link ServerName}
* @return the relative WAL directory name
*/
- public static String getWALArchiveDirectoryName(Configuration conf, final
String serverName) {
+ public static String getWALArchiveDirectoryName(Configuration conf, String
serverName) {
StringBuilder dirName = new
StringBuilder(HConstants.HREGION_OLDLOGDIR_NAME);
if (conf.getBoolean(SEPARATE_OLDLOGDIR, DEFAULT_SEPARATE_OLDLOGDIR)) {
+ // If ServerName is IPV6 address, then need to encode server address
+ if (ServerName.isIpv6ServerName(serverName, ServerName.COLON)) {
Review Comment:
Thanks @srinireddy2020 for bringing this. We also need to check the impact
on Web UI links, HDFS block locality calculation, RSGroup etc. Please create an
umbrella JIRA and list the sub-tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
