vinayakphegde commented on code in PR #7222:
URL: https://github.com/apache/hbase/pull/7222#discussion_r2274143751
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/replication/ContinuousBackupReplicationEndpoint.java:
##########
@@ -298,11 +301,21 @@ private void backupWalEntries(long day, List<WAL.Entry>
walEntries) throws IOExc
try {
FSHLogProvider.Writer walWriter = walWriters.computeIfAbsent(day,
this::createWalWriter);
+ List<Path> bulkLoadFiles =
BulkLoadProcessor.processBulkLoadFiles(walEntries);
+
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("{} Processed {} bulk load files for WAL entries",
Utils.logPeerId(peerId),
+ bulkLoadFiles.size());
+ LOG.trace("{} Bulk load files: {}", Utils.logPeerId(peerId),
+
bulkLoadFiles.stream().map(Path::toString).collect(Collectors.joining(", ")));
+ }
for (WAL.Entry entry : walEntries) {
walWriter.append(entry);
}
+
walWriter.sync(true);
+ uploadBulkLoadFiles(day, bulkLoadFiles);
Review Comment:
Yes, we considered and discussed this. We decided to keep it synchronous for
now, as making it asynchronous would add complexity and might be a premature
optimization. We can revisit this approach if it turns out to be a real
performance bottleneck.
Any other thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
