guluo2016 commented on code in PR #7071:
URL: https://github.com/apache/hbase/pull/7071#discussion_r2128647416
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java:
##########
@@ -271,4 +283,13 @@ public void stop(String why) {
public boolean isStopped() {
return this.stopped;
}
+
+ /**
+ * Check if asyncClusterConnection is closed
+ * @return true if asyncClusterConnection is not null and is closed, false
otherwise
+ */
+ private boolean isAsyncClusterConnectionClosed() {
+ AsyncClusterConnection asyncClusterConnection =
masterService.getAsyncClusterConnection();
+ return asyncClusterConnection != null && asyncClusterConnection.isClosed();
Review Comment:
A null check for asyncClusterConnection here, as HMaster performs the same
check.
```java
// HMaster.shutdown()
if (this.asyncClusterConnection != null) {
this.asyncClusterConnection.close();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
