mwkang commented on code in PR #6900:
URL: https://github.com/apache/hbase/pull/6900#discussion_r2061317671
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java:
##########
@@ -832,7 +845,7 @@ private void updateMetricsStore(boolean memstoreRead) {
* @return null is the top cell doesn't change. Otherwise, the NextState to
return
*/
private NextState needToReturn(List<? super ExtendedCell> outResult) {
- if (!outResult.isEmpty() && topChanged) {
+ if (topChanged) {
Review Comment:
Thanks again for the detailed review and your follow-up questions — I really
appreciate it.
I feel that my earlier explanation may not have been clear enough.
To clarify: the main issue is not with partial results, but rather with **a
single row being split into two separate results**.
This split happens because after a topChanged event, if outResult is empty,
StoreScanner doesn't correctly detect that the row has changed.
(Upon reflecting on our [previous
discussion](https://github.com/apache/hbase/pull/6900#discussion_r2039658867),
I realized that my initial explanation may not have been as clear as it should
have been. When I first encountered this issue, I thought it was related to
partial results, which is why I initially mentioned that in
[thread](https://lists.apache.org/thread/2wj5rq922lfxj37ohk5ctr42bn9pyrl4).
However, after further debugging, the core issue is actually that a single row
is being split into two separate Results. I apologize if my earlier explanation
was confusing, and I'm sorry for not making this clearer sooner.)
I’ve [already added a reproducible test
case](https://github.com/apache/hbase/pull/6900#discussion_r2051976496)
([TestTopChanged.testTopChanged](https://github.com/mwkang/hbase/blob/feature/bug-demo-HBASE-29254/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTopChanged.java)
in the [feature/bug-demo-HBASE-29254
branch](https://github.com/mwkang/hbase/tree/feature/bug-demo-HBASE-29254)) to
demonstrate this behavior.
Please let me know if there’s anything else you would like me to work on to
help move this forward.
Thanks again for your time and support!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
