rmdmattingly commented on code in PR #6821:
URL: https://github.com/apache/hbase/pull/6821#discussion_r2003298744
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerConditionals.java:
##########
@@ -145,7 +145,7 @@ int getViolationCountChange(BalancerClusterState cluster,
BalanceAction action)
// Reset cluster
cluster.doAction(undoAction);
- if (isViolatingPre && isViolatingPost) {
+ if (isViolatingPre == isViolatingPost) {
return 0;
Review Comment:
We also want to return 0 if we had zero violations both pre & post. Prior to
this fix, we'd fall through to return -1 which erroneously considered a neutral
move to be an improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
