[ 
https://issues.apache.org/jira/browse/HBASE-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287868#comment-16287868
 ] 

Josh Elser commented on HBASE-19289:
------------------------------------

bq. put the property in test/resources/hbase-site.xml

That's a nice trick! 

{code}
<description>We don't need to enforce stream capabilities in tests using local 
FS</description>
{code}

How about instead: "Controls whether or not HBase will require stream 
capabilities (hflush) in tests using the LocalFileSystem class".

Nit: TestHStore.java has a whitespace-only change.

bq. AFAICT anybody starting HBase on local file system is going to run straight 
into a brick wall.

Need to return to this too, eh? The 
[book|https://hbase.apache.org/book.html#_get_started_with_hbase] does have 
instructions for users to create an hbase-site.xml -- is updating this 
sufficient? A release note is obviously good to warn users. Is the error 
message a user would find if they _didn't_ set this property sufficient to lead 
them to somewhere that will clearly show them how to fix the problem (e.g. via 
a web-search)?

> CommonFSUtils$StreamLacksCapabilityException: hflush when running test 
> against hadoop3 beta1
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19289
>                 URL: https://issues.apache.org/jira/browse/HBASE-19289
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Mike Drob
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: 19289.v1.txt, 19289.v2.txt, HBASE-19289.patch, 
> HBASE-19289.v2.patch, HBASE-19289.v3.patch, HBASE-19289.v4.patch
>
>
> As of commit d8fb10c8329b19223c91d3cda6ef149382ad4ea0 , I encountered the 
> following exception when running unit test against hadoop3 beta1:
> {code}
> testRefreshStoreFiles(org.apache.hadoop.hbase.regionserver.TestHStore)  Time 
> elapsed: 0.061 sec  <<< ERROR!
> java.io.IOException: cannot get log writer
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.initHRegion(TestHStore.java:215)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:220)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:195)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:190)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:185)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:179)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:173)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.testRefreshStoreFiles(TestHStore.java:962)
> Caused by: 
> org.apache.hadoop.hbase.util.CommonFSUtils$StreamLacksCapabilityException: 
> hflush
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.initHRegion(TestHStore.java:215)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:220)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:195)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:190)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:185)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:179)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.init(TestHStore.java:173)
>       at 
> org.apache.hadoop.hbase.regionserver.TestHStore.testRefreshStoreFiles(TestHStore.java:962)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to