[ 
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261976#comment-16261976
 ] 

Ashish Singhi commented on HBASE-16868:
---------------------------------------

+1 on the patch.
Nit(can address on the commit): 
{code}
31        If replicate_all flag is false, then all user tables cannot be 
replicate to
32        peer cluster. But you can set NAMESPACES or TABLECFS to include some 
tables
33        which will be replicated.
{code}
It will be good if we can explain the user here, how to set NAMESPACES or 
TABLECFS. We can just mention the command which one to use to do it.

> Add a replicate_all flag to avoid misuse the namespaces and table-cfs config 
> of replication peer
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16868
>                 URL: https://issues.apache.org/jira/browse/HBASE-16868
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>    Affects Versions: 2.0.0, 3.0.0
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-16868.master.001.patch, 
> HBASE-16868.master.002.patch, HBASE-16868.master.003.patch, 
> HBASE-16868.master.004.patch, HBASE-16868.master.005.patch, 
> HBASE-16868.master.006.patch, HBASE-16868.master.007.patch, 
> HBASE-16868.master.008.patch
>
>
> First add a new peer by shell cmd.
> {code}
> add_peer '1', CLUSTER_KEY => "server1.cie.com:2181:/hbase".
> {code}
> If we don't set namespaces and table cfs in peer config. It means replicate 
> all tables to the peer cluster.
> Then append a table to the peer config.
> {code}
> append_peer_tableCFs '1', {"table1" => []}
> {code}
> Then this peer will only replicate table1 to the peer cluster. It changes to 
> replicate only one table from replicate all tables in the cluster. It is very 
> easy to misuse in production cluster. So we should avoid appending table to a 
> peer which replicates all table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to