[
https://issues.apache.org/jira/browse/HBASE-19280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257328#comment-16257328
]
Anoop Sam John commented on HBASE-19280:
----------------------------------------
How using the returned Compression.Algorithm? I can see Compression class is
marked Private and inside enum Algorithm is marked Public.
getCompressionAlgorithmByName(String compressName) is there in Compression
class also. We should decide what all the be exposed clearly from Compression
and Algorithm.
Oh ya we have setter to set compression types in HCD etc. For that may be this
Algorithm enum is exposed now. Only the type names were needed to be exposed
ideally.
> Move HFileWriterImpl.compressionByName(String name) to some utility class
> -------------------------------------------------------------------------
>
> Key: HBASE-19280
> URL: https://issues.apache.org/jira/browse/HBASE-19280
> Project: HBase
> Issue Type: Bug
> Reporter: Ankit Singhal
> Priority: Trivial
> Fix For: 2.0.0-beta-2
>
>
> This method can be moved to some utility (related jira PHOENIX-4368).
> {code}
> public static Compression.Algorithm compressionByName(String algoName) {
> if (algoName == null)
> return HFile.DEFAULT_COMPRESSION_ALGORITHM;
> return Compression.getCompressionAlgorithmByName(algoName);
> }
> {code}
> FYI, [~elserj]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
