[
https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209468#comment-16209468
]
Mike Drob commented on HBASE-14093:
-----------------------------------
bq. I haven't moved the logic of downloading and extracting bootstrap and
jquery to hbase-assembly, because this way we have a simple, easy to test web
module, which doesn't depend on anything. The files fit into this project, and
hbase-assembly can stay consistent.
Ok, taking a second look, I realized this isn't what I was asking about.
In hbase-static-web-resources/pom.xml we have
{noformat}
+ <execution>
+ <id>unpack-bootstrap</id>
+ <configuration>
+
<outputDirectory>${project.build.directory}/generated-resources</outputDirectory>
+ </configuration>
+ </execution>
...
+ <execution>
+ <id>copy-bootstrap-resources</id>
+ <phase>process-resources</phase>
+ <goals>
+ <goal>copy-resources</goal>
+ </goals>
+ <configuration>
+
<outputDirectory>${project.build.outputDirectory}/hbase-webapps/static</outputDirectory>
+ <resources>
+ <resource>
+ <directory>
+
${project.build.directory}/generated-resources/META-INF/resources/webjars/bootstrap/${bootstrap.version}
+ </directory>
+ </resource>
+ </resources>
+ </configuration>
+ </execution>
{noformat}
Do we do this because we don't actually want everything from the bootstrap
download included? Or maybe it looks like the directory structure is too deep
initially?
Why can't we unpack directly to {{hbase-webapps/static}}, is what I'm trying to
get at...
> deduplicate copies of bootstrap files
> -------------------------------------
>
> Key: HBASE-14093
> URL: https://issues.apache.org/jira/browse/HBASE-14093
> Project: HBase
> Issue Type: Improvement
> Components: build
> Reporter: Sean Busbey
> Assignee: Tamas Penzes
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-14093.master.001.patch,
> HBASE-14093.master.002.patch, HBASE-14093.master.002.patch,
> HBASE-14093.master.003.patch, HBASE-14093.master.003.patch,
> HBASE-14093.master.004.patch, patch-shadedjars.txt
>
>
> right now we have a couple of different copies of the bootstrap js and css
> files. It'll be easier to maintain them later if we can centralize.
> Move them to a common location and use maven to populate them as needed in
> various component build directories.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
