[ 
https://issues.apache.org/jira/browse/HBASE-18707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144896#comment-16144896
 ] 

Tamas Penzes edited comment on HBASE-18707 at 8/29/17 8:05 AM:
---------------------------------------------------------------

Hi [~stack],

We basically have two main options:
* put all the files into each webapplication and use them locally
* only put it into the server and use them remotely
* (I would avoid the mixed option since it would make things tricky)

In the first case the JARs will be bigger, but they will be independent from 
each other. We can get the web UI of each component without loading anything 
from the server.
It is a question if we need that level of independence, but the information 
provided by the web UIs can be useful when facing issues.

In the second case we would only include the CSS, JS and font files into the 
hbase-server module.
Since each running module knows the master server's URL we could load these 
files remotely. If the master is not available we have problems anyway, so the 
design of the web UI will be our smallest issue, but to get useful info through 
the web UI would be harder.
Some browsers (e.g. IE, FF) don't like loading fonts remotely and loading 
external JS files can also cause strange browser messages and/or XSS alerts.

This is why I thought we should include the files into the JAR.

I also work on minimising the source code in HBASE-14093, which would mean that 
we only included the files in build time.
We could also remove non-minimised CSS and JS files, but they would make it 
harder to read them when needed. (We could differentiate dev and prod builds 
and include normal or minimised files based on them, but I think it would just 
be l'art pour l'art programming this case.)
Since we work with big data, I don't think a few CSS and JS files will cause 
any problem.


was (Author: tamaas):
Hi [~stack],

We basically have two main options:
* put all the files into each webapplication and use them locally
* only put it into the server and use them remotely
* (I would avoid the mixed option since it would make things tricky)

In the first case the JARs will be bigger, but they will be independent from 
each other. We can get the web UI of each component without loading anything 
from the server.
It is a question if we need that level of independence, but the information 
provided by the web UIs can be useful when facing issues.

In the second case we would only include the CSS, JS and font files into the 
hbase-server module.
Since each running module knows the master server's URL we could load these 
files remotely. If the master is not available we have problems anyway, so the 
design of the web UI will be our smallest issue, but to get useful info through 
the web UI would be harder.
Some browsers (e.g. IE, FF) don't like loading fonts remotely and loading 
external JS files can also cause strange browser messages and/or XSS alerts.

This is why I thought we should include the files into the JAR.

I also work on minimising the source code in HBASE-14093, which would mean that 
we only included the files in build time.
We could also remove non-minimised CSS and JS files, but they would make it 
harder to read them when needed. (We could differentiate dev and prod builds 
and include normal or minimised files based on them, but I think it would just 
be l'art pour l'art programming this case.)
Since we work with big data, I don't think a few CSS and JS files will block 
our work.

> Rest server's web UI doesn't contain bootstrap files
> ----------------------------------------------------
>
>                 Key: HBASE-18707
>                 URL: https://issues.apache.org/jira/browse/HBASE-18707
>             Project: HBase
>          Issue Type: Bug
>          Components: REST
>    Affects Versions: 2.0.0
>            Reporter: Tamas Penzes
>            Assignee: Tamas Penzes
>         Attachments: HBASE-18707.master.001.patch
>
>
> CSS, JS and font files are totally missing from the webapp of the rest module



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to