[ 
https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125782#comment-16125782
 ] 

brandboat commented on HBASE-8518:
----------------------------------

To keep this test "testRecoveredEditsReplayCompaction()", there must have a way 
to let compaction not complete. 
What I have already thought now is add another TestHRegion extends from 
HRegion, overriding all method which uses HStore and replace all HStore to 
TestHStore which has a method that we can trigger compaction not complete. 
But the problem is if HRegion has something changed inside the mehtod that I 
have already overrided, this patch would lose efficacy.

> Get rid of hbase.hstore.compaction.complete setting
> ---------------------------------------------------
>
>                 Key: HBASE-8518
>                 URL: https://issues.apache.org/jira/browse/HBASE-8518
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: brandboat
>            Priority: Minor
>              Labels: beginner
>         Attachments: HBASE-8518-1.patch
>
>
> hbase.hstore.compaction.complete is a strange setting that causes the 
> finished compaction to not complete (files are just left in tmp) in HStore. 
> It's used by one test.
> The setting with the same name is also used by CompactionTool, but that usage 
> is semi-unrelated and could probably be removed easily.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to