[
https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HBASE-18555:
-----------------------------
Description:
In Put#addColumn() and addImmutable(), after getting cell list of the given
family and add the cell into the list, the code will put (key=family,
value=list) into family map.
In addColumn(), it is like
{code}
List<Cell> list = getCellList(family);
KeyValue kv = createPutKeyValue(family, qualifier, ts, value);
list.add(kv);
familyMap.put(CellUtil.cloneFamily(kv), list); // <-- here
return this;
{code}
In addImmutable(), it is like
{code}
List<Cell> list = getCellList(family);
KeyValue kv = createPutKeyValue(family, qualifier, ts, value, tag);
list.add(kv);
familyMap.put(family, list); // <-- here
return this;
{code}
> Remove redundant familyMap.put() from Put#addColumn() and addImmutable()
> ------------------------------------------------------------------------
>
> Key: HBASE-18555
> URL: https://issues.apache.org/jira/browse/HBASE-18555
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Reporter: Xiang Li
> Assignee: Xiang Li
> Priority: Minor
>
> In Put#addColumn() and addImmutable(), after getting cell list of the given
> family and add the cell into the list, the code will put (key=family,
> value=list) into family map.
> In addColumn(), it is like
> {code}
> List<Cell> list = getCellList(family);
> KeyValue kv = createPutKeyValue(family, qualifier, ts, value);
> list.add(kv);
> familyMap.put(CellUtil.cloneFamily(kv), list); // <-- here
> return this;
> {code}
> In addImmutable(), it is like
> {code}
> List<Cell> list = getCellList(family);
> KeyValue kv = createPutKeyValue(family, qualifier, ts, value, tag);
> list.add(kv);
> familyMap.put(family, list); // <-- here
> return this;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
