[
https://issues.apache.org/jira/browse/HBASE-18398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117858#comment-16117858
]
Ted Yu commented on HBASE-18398:
--------------------------------
{code}
+ public void preFsSnapshot() {
{code}
Can Fs in the method name be removed ? There is only one snapshot operation in
hbase.
TestSnapshot needs to carry test category.
I only see testAddRegionWithCompactions in the class. Can you make the class
name more specific ? There are some snapshot test classes already.
Can you measure the impact of this change on snapshot performance ?
> Snapshot operation fails with FileNotFoundException
> ---------------------------------------------------
>
> Key: HBASE-18398
> URL: https://issues.apache.org/jira/browse/HBASE-18398
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Reporter: Ashu Pachauri
> Assignee: Ashu Pachauri
> Fix For: 1.3.2
>
> Attachments: HBASE-18398.master.001.patch
>
>
> Failing to take snapshot due to FileNotFoundException
> * FlushSnapshotSubprocedure.RegionSnapshotTask takes a region level read
> lock
> * Call to HRegion#addRegionToSnapshot.
> * Call to SnapshotManifest#addRegion. This gets the current list of store
> files.
> * RACE → File is marked as compacted away and HFileArchiver moves the
> file to archive under store level lock.
> * SnapshotManifest#addRegion visits the stale list of store files one by
> one. It does a file.getStatus() call to get length of each file. Since the
> file object still points to the original file, file.getStatus() fails with
> FileNotFoundException.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
