[ 
https://issues.apache.org/jira/browse/HBASE-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099369#comment-16099369
 ] 

Mike Drob commented on HBASE-18438:
-----------------------------------

Second patch run found the unused import. 
https://builds.apache.org/job/PreCommit-HBASE-Build/7774/artifact/patchprocess/maven-patch-checkstyle-hbase-common.txt

It even had 1646 violations as compared to 1341 before the patch (guess the 
300-some come from enabling the test source check).

I don't understand why this didn't fail that check for me though. [~busbey] - 
ball's back in your court.

> Precommit doesn't warn about unused imports
> -------------------------------------------
>
>                 Key: HBASE-18438
>                 URL: https://issues.apache.org/jira/browse/HBASE-18438
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>         Attachments: HBASE-18438.patch, HBASE-18438.v2.patch
>
>
> On HBASE-18419 I accidentally included an unused import in my patch, but 
> precommit didn't flag it. Use this issue to diagnose and fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to