[
https://issues.apache.org/jira/browse/HBASE-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088616#comment-16088616
]
Jan Kunigk commented on HBASE-16415:
------------------------------------
Hello, sorry for the delay and thanks for the feedback. I have created
https://reviews.apache.org/r/60896/
With regards to the above questions (not addressed the posting on reviewboard
yet):
> please move the javadoc starting with...
Changed
> Please add annotation for audience for
> RedirectingInterClusterReplicationEndpoint (Private).
done
> For redirectEntries(), tableRedirectionsMap is populated. This action can be
> lifted outside redirectEntries()
Can you point me to a good place where it should go? Are you thinking to
override init() with super.init() and populate it in there? The way I
understand it init may not suffice. The mapping may be changed in between,
correct?
> IllegalArgumentException can come from parsing val - adjust message
> accordingly. This shouldn't be at INFO level.
Agree, changed to LOG.warn
> Replication in different namespace
> ----------------------------------
>
> Key: HBASE-16415
> URL: https://issues.apache.org/jira/browse/HBASE-16415
> Project: HBase
> Issue Type: New Feature
> Components: Replication
> Reporter: Christian Guegi
> Assignee: Jan Kunigk
> Attachments: HBASE-16415.patch
>
>
> It would be nice to replicate tables from one namespace to another namespace.
> Example:
> Master cluster, namespace=default, table=bar
> Slave cluster, namespace=dr, table=bar
> Replication happens in class ReplicationSink:
> public void replicateEntries(List<WALEntry> entries, final CellScanner
> cells, ...){
> ...
> TableName table =
> TableName.valueOf(entry.getKey().getTableName().toByteArray());
> ...
> addToHashMultiMap(rowMap, table, clusterIds, m);
> ...
> for (Entry<TableName, Map<List<UUID>, List<Row>>> entry :
> rowMap.entrySet()) {
> batch(entry.getKey(), entry.getValue().values());
> }
> }
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
