[
https://issues.apache.org/jira/browse/HBASE-17975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989257#comment-15989257
]
Sean Busbey commented on HBASE-17975:
-------------------------------------
{quote}
-1 test4tests 0m 0s The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch.
{quote}
no tests because we don't have a reliable way to include "the remote side threw
an exception" in our delegation token handling AFAIK.
{quote}
Failed junit tests hadoop.hbase.snapshot.TestSecureExportSnapshot
hadoop.hbase.snapshot.TestMobExportSnapshot
hadoop.hbase.snapshot.TestExportSnapshot
hadoop.hbase.snapshot.TestMobSecureExportSnapshot
{quote}
These are HBASE-17970, which I'm pushing as soon as my local build finishes.
> TokenUtil.obtainToken squashes remote exceptions
> ------------------------------------------------
>
> Key: HBASE-17975
> URL: https://issues.apache.org/jira/browse/HBASE-17975
> Project: HBase
> Issue Type: Bug
> Components: mapreduce, security
> Affects Versions: 2.0.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-17975.0.patch
>
>
> In the changes to protobuf handling in HBASE-15638, our TokenUtil class went
> from handling remote exception via a method that would throw IOException to
> one that simply returned it. In doing so, we ended up ignoring the results.
> This causes the obtainToken method to start returning null where it would
> have previously thrown an IOException. It also causes obtainTokenForJob to
> still fail with an IOException, but instead of being the underlying remote
> problem now it's a generic "I didn't get a user token for some reason."
> found via testing Pig with errors.
> {code}
> Caused by: java.io.IOException: No token returned for user
> [email protected]
> at
> org.apache.hadoop.hbase.security.token.TokenUtil.obtainTokenForJob(TokenUtil.java:175)
> at
> org.apache.pig.backend.hadoop.hbase.HBaseStorage.addHBaseDelegationToken(HBaseStorage.java:887)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
