[ 
https://issues.apache.org/jira/browse/HBASE-17627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866560#comment-15866560
 ] 

Gary Helmling commented on HBASE-17627:
---------------------------------------

+1 on the patch from review board.

Can you check the test failure and see if it is related?

They way we currently expose number of active handlers, here and in the 
RpcServer, is a bit flawed.  Since it is a point in time metric, it can miss 
spikes in activity which clear before the metrics collection happen.  
Ultimately it might be better to report something like "number of handler 
milliseconds consumed" (millis duration for each call, summed up), but that is 
really a separate discussion.

Anyway, this change is much better than what we currently have, or don't have 
rather.

> Active workers metric for thrift
> --------------------------------
>
>                 Key: HBASE-17627
>                 URL: https://issues.apache.org/jira/browse/HBASE-17627
>             Project: HBase
>          Issue Type: Improvement
>          Components: Thrift
>            Reporter: Ashu Pachauri
>            Assignee: Ashu Pachauri
>         Attachments: HBASE-17627.master.001.patch
>
>
> It would be good to have a metric for number of active handlers on thrift 
> servers, which gives a good indication of business of a thrift server.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to