[
https://issues.apache.org/jira/browse/HBASE-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853611#comment-15853611
]
Anoop Sam John commented on HBASE-17575:
----------------------------------------
bq.No dirty reads since these scanners are currently only used by the
compacting scanner which is a store scanner that uses SQM to get the right
results.
Still the comments above this line says
// create the list of scanners with the smallest read point, meaning that
// only relevant KVs are going to be returned by the pipeline traversing
You better change this and say why no readPnt being used.
{quote}
TestAcidGuarantees
conf.setBoolean(MemStoreLAB.USEMSLAB_KEY, false);
{quote}
Can we do this set iff the compacting memstore usage in place? ie.compType !=
NONE
Else looks good.
> Run critical tests with each of the Inmemory Compaction Policies enabled
> (Towards Making BASIC the Default In-Memory Compaction Policy)
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-17575
> URL: https://issues.apache.org/jira/browse/HBASE-17575
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Reporter: Eshcar Hillel
> Assignee: Eshcar Hillel
> Fix For: 2.0.0
>
> Attachments: HBASE-17575-V01.patch, HBASE-17575-V01.patch
>
>
> In preparation for switching the default in-memory compaction policy to
> BASIC, we would like to make sure that once we do the switch all tests will
> run (and pass!) with the new default policy.
> To this end, we remove the NONE configuration setting added to tests in
> HBASE-17294 and HBASE-17316.
> We verified these tests pass with all 3 memory compaction policies.
> For each test
> (1) if all 3 policies pass the test -- we remove the configuration from the
> test.
> (2) if some fail we add tests of all 3 configurations, e.g., by parameterized
> tests. When needed we update expected results.
> One test failure identified a small bug which is also fixed in the patch.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
