[
https://issues.apache.org/jira/browse/HBASE-17191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15708261#comment-15708261
]
ramkrishna.s.vasudevan commented on HBASE-17191:
------------------------------------------------
Some where I remember that for non-java client cases we were not doing that -
in case of CP? I don't remember. REading the code it seems we seem to set the
callback for any case. So in the current code - even for a non-java client case
we were returning back the buffers only after the response was formed and
anyway the response was like copied from the buffer to some byte[]? Then fine.
> Make use of UnsafeByteOperations#unsafeWrap(ByteBuffer buffer) in
> PBUtil#toCell(Cell cell)
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-17191
> URL: https://issues.apache.org/jira/browse/HBASE-17191
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
>
> Since we now have support for BBs in
> UnsafeByteOperations#unsafeWrap(ByteBuffer) . So for the non - java clients
> while creating the PB result we could avoid the copy to an temp array.
> Since we have a support to write to BB in ByteOutput having a result backed
> by Bytebuffer should be fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
