[
https://issues.apache.org/jira/browse/HBASE-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15679169#comment-15679169
]
Xiang Li commented on HBASE-17126:
----------------------------------
Hi [~anoop.hbase], thanks for the comments! I uploaded patch 003 to
(1) Put the definition of MAX_TAGS_LENGTH at the head of the file before any
method declaration
(2) Change access of checkForTagsLength() from package-private to public.
(still keep MAX_TAGS_LENGTH as private in TagUtil)
(3) Add more comments
Might it be more proper to put checkForTagsLength() and MAX_TAGS_LENGTH into
CellUtil? I think TagUtil is for a single tag, while tags would fit more into
CellUtil. Any comments?
> Expose KeyValue#checkParameters() and checkForTagsLength() to be used by
> other Cell implementations
> ---------------------------------------------------------------------------------------------------
>
> Key: HBASE-17126
> URL: https://issues.apache.org/jira/browse/HBASE-17126
> Project: HBase
> Issue Type: Improvement
> Components: Client, regionserver
> Affects Versions: 2.0.0
> Reporter: Xiang Li
> Assignee: Xiang Li
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-17126.master.000.patch,
> HBASE-17126.master.001.patch
>
>
> KeyValue has 2 useful but private functions to check input parameters, as
> - checkParameters()
> - checkForTagsLength()
> It would be great if their's access could be not private, so that they can be
> used by other Cell or ExtendedCell implementations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
