[
https://issues.apache.org/jira/browse/HBASE-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575117#comment-15575117
]
ramkrishna.s.vasudevan commented on HBASE-16792:
------------------------------------------------
I verified the code and the reason for failure of the V1 patch. Actually the
failures were due to test case the way it operates. We were seeking for a key
and direcly calling getCell. In actual case it does not happen. Since we had
invalidated the byte[] itself both previous and current were sharing that
byte[]. So when we did getCell it failed. May be in actual case it does not
happen.
So it is better to go with V2 patch only. +1 for V2/V3.
Will commit unless objections.
> Reuse KeyValue.KeyOnlyKeyValue in BufferedDataBlockEncoder.SeekerState
> ----------------------------------------------------------------------
>
> Key: HBASE-16792
> URL: https://issues.apache.org/jira/browse/HBASE-16792
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: binlijin
> Assignee: binlijin
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-16792_master.patch, HBASE-16792_master_v2.patch,
> HBASE-16792_master_v3.patch
>
>
> When every SeekerState#invalidate will new a fresh KeyValue.KeyOnlyKeyValue,
> we should reuse it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
