[
https://issues.apache.org/jira/browse/HBASE-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527253#comment-15527253
]
Guang Yang commented on HBASE-16686:
------------------------------------
Thanks [~apurtell] for the review.
{quote}
Convention across the code base is to use EnvironmentEdgeManager#getTime()
instead of System#currentTimeMillis so the time can be controlled in unit tests
{quote}
Thanks for pointing that out, will update the patch accordingly.
{quote}
While a simple count of exceptions could be useful, does it make sense to break
down the counts for common exceptions of interest?
{quote}
Yeah that would be helpful, let me take a look at the common exceptions that we
may report individually.
As for this patch, I will first focus on getting Jetty 9 work
(https://issues.apache.org/jira/browse/HBASE-12894), and then consolidate a
patch for metrics, since it would be helpful to have some metrics from Jetty as
well (e.g. queue length, busy/idle threads, etc.).
> Add latency metrics for REST
> ----------------------------
>
> Key: HBASE-16686
> URL: https://issues.apache.org/jira/browse/HBASE-16686
> Project: HBase
> Issue Type: New Feature
> Components: monitoring, REST
> Reporter: Guang Yang
> Priority: Minor
> Attachments: HBASE-16686_v0.patch
>
>
> It would be helpful to have the latency metrics for rest for various
> operations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
