[
https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456497#comment-15456497
]
Ted Yu commented on HBASE-16465:
--------------------------------
{code}
+ private boolean safeMode = true;
{code}
Mode implies enum. Please rename the variable.
{code}
+ boolean balancer = false;
{code}
Please name the variable balancerEnabled.
{code}
+ if (isFullBackup && userRequest.isSafeMode()) {
{code}
Should default value for safe mode be off ?
For testFullBackupMultipleCommandUnsafe, I don't see induced split / merge.
> Disable region splits and merges, balancer during full backup
> -------------------------------------------------------------
>
> Key: HBASE-16465
> URL: https://issues.apache.org/jira/browse/HBASE-16465
> Project: HBase
> Issue Type: Improvement
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch,
> HBASE-16465-v3.patch, HBASE-16465-v4.patch
>
>
> Incorporate HBASE-15128
> Balancer, catalog janitor and region normalizer should be disabled as well
> during full backup
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
