[ 
https://issues.apache.org/jira/browse/HBASE-16528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449081#comment-15449081
 ] 

Matteo Bertozzi commented on HBASE-16528:
-----------------------------------------

you can just do setOwner(Superusers.getSystemUser()) in the 
ServerCrashProcedure constructor. 
or you follow all the other procedures passing env, like you did, and use 
setOwner(env.getRequestUser().getShortName()) but there is no need of all that 
try/catch check for null and similar.


> Procedure-V2: ServerCrashProcedure misses owner information
> -----------------------------------------------------------
>
>                 Key: HBASE-16528
>                 URL: https://issues.apache.org/jira/browse/HBASE-16528
>             Project: HBase
>          Issue Type: Bug
>          Components: hbase, master, proc-v2
>    Affects Versions: 2.0.0, 1.1.5
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>         Attachments: HBASE-16528.v1-master.patch
>
>
> ServerCrashProcedure constructor does not set up owner information.  If 
> someone wants to access the owner of ServerCrashProcedure, it would get NPE 
> (eg. in case someone accidentally tries to abort a ServerCrashProcedure, the 
> coprocessor to check owner of the procedure would throw NPE)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to