[
https://issues.apache.org/jira/browse/HBASE-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425153#comment-15425153
]
stack commented on HBASE-16433:
-------------------------------
To be clear, you are undoing the AsyncRpcChannel because we should adhere to
the protobuf generated nonblocking APIs when doing async and AsyncRpcChannel
as-is short-circuiting skipping providing the callback?
Patch also undoes the leaking of netty in our API.
I skimmed through it. Patch looks good to me. [~jurmous] -- any input sir? It
looks like this patch preserves the work done so far making it better contained.
+1 Patch looks good and moves this async forward another step. Thanks [~Apache9]
> Remove AsyncRpcChannel related stuffs
> -------------------------------------
>
> Key: HBASE-16433
> URL: https://issues.apache.org/jira/browse/HBASE-16433
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-16433.patch
>
>
> AsyncRpcChannel can not be used by protobuf stub. We should implement the
> async logic along with the RpcChannel interface of protobuf.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
