[
https://issues.apache.org/jira/browse/HBASE-15844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358320#comment-15358320
]
Anoop Sam John commented on HBASE-15844:
----------------------------------------
+1
Minor suggestion can fix on commit. We have a private method getCacheOnWrite()
doing this new if check. Just use that.
> We should respect hfile.block.index.cacheonwrite when write intermediate
> index Block
> ------------------------------------------------------------------------------------
>
> Key: HBASE-15844
> URL: https://issues.apache.org/jira/browse/HBASE-15844
> Project: HBase
> Issue Type: Bug
> Reporter: Heng Chen
> Fix For: 2.0.0
>
> Attachments: HBASE-15844.patch
>
>
> {code: title=BlockIndexWriter#writeIntermediateBlock}
> if (cacheConf != null) {
> HFileBlock blockForCaching =
> blockWriter.getBlockForCaching(cacheConf);
> cacheConf.getBlockCache().cacheBlock(new BlockCacheKey(nameForCaching,
> beginOffset, true, blockForCaching.getBlockType()),
> blockForCaching);
> }
> {code}
> The if condition should be ?
> {code}
> if (cacheConf != null && cacheConf.shouldCacheIndexesOnWrite())
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
