[
https://issues.apache.org/jira/browse/HBASE-16033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333345#comment-15333345
]
Yu Li commented on HBASE-16033:
-------------------------------
Checked the failed UT cases:
1. org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.testScanSize
{noformat}
Metrics Counters should be equal expected:<30> but was:<31>
java.lang.AssertionError: Metrics Counters should be equal expected:<30> but
was:<31>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at
org.apache.hadoop.hbase.test.MetricsAssertHelperImpl.assertCounter(MetricsAssertHelperImpl.java:185)
at
org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.assertRegionMetrics(TestRegionServerMetrics.java:164)
at
org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.testScanSize(TestRegionServerMetrics.java:363)
{noformat}
2. org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.testScanTime
{noformat}
Metrics Counters should be equal expected:<92> but was:<93>
java.lang.AssertionError: Metrics Counters should be equal expected:<92> but
was:<93>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at
org.apache.hadoop.hbase.test.MetricsAssertHelperImpl.assertCounter(MetricsAssertHelperImpl.java:185)
at
org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.assertCounter(TestRegionServerMetrics.java:146)
at
org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.testScanTime(TestRegionServerMetrics.java:382)
{noformat}
None is irrelative to the change here, and confirmed all could pass in my local
env, should be some intermittent failures.
> Add more details in logging of responseTooSlow/TooLarge
> -------------------------------------------------------
>
> Key: HBASE-16033
> URL: https://issues.apache.org/jira/browse/HBASE-16033
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.2.1
> Reporter: Yu Li
> Assignee: Yu Li
> Fix For: 2.0.0, 1.3.1
>
> Attachments: HBASE-16033.patch, HBASE-16033.patch, HBASE-16033.patch
>
>
> Currently the log message when responseTooSlow/TooLarge is like:
> {noformat}
> 2016-06-08 12:18:04,363 WARN
> [B.defaultRpcServer.handler=127,queue=10,port=16020]
> ipc.RpcServer: (responseTooSlow):
> {"processingtimems":13125,"call":"Multi(org.apache.hadoop.hbase.protobuf.generated.ClientProtos$MultiRequest)",
> "client":"11.251.158.22:36331","starttimems":1465359471238,"queuetimems":1540116,
> "class":"HRegionServer","responsesize":17,"method":"Multi"}
> {noformat}
> which is kind of helpless for debugging since we don't know on which
> table/region/row the request is against.
> What's more, we could see some if-else check in the {{RpcServer#logResponse}}
> method which trying to do sth different when the {{param}} includes instance
> of {{Operation}}, but there's only one place invoking {{logResponse}} and the
> {{param}} is always an instance of {{Message}}. Checking the change history,
> I believe this is a left-over cleanup in work of HBASE-8214
> We will address the above issues, do some cleanup and improve the log just
> like {{RpcServer$Call#toString}} does to include table/region/row information
> of the request
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
