[
https://issues.apache.org/jira/browse/HBASE-15615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264583#comment-15264583
]
Gary Helmling commented on HBASE-15615:
---------------------------------------
The changes look good. The test provides decent coverage of getPauseTime(),
which was lacking, but wouldn't actually have found the problem with the usages
here though. Can you add in tests for the values returned by the sleep() calls
modified here in RegionAdminServiceCallable and RegionServerCallable?
I actually think the ntries check is a good safety measure.
> Wrong sleep time when RegionServerCallable need retry
> -----------------------------------------------------
>
> Key: HBASE-15615
> URL: https://issues.apache.org/jira/browse/HBASE-15615
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.0.0, 2.0.0, 1.1.0, 1.2.0, 1.3.0
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Fix For: 1.3.0
>
> Attachments: HBASE-15615-branch-1.patch, HBASE-15615-v1.patch,
> HBASE-15615-v1.patch, HBASE-15615.patch
>
>
> In RpcRetryingCallerImpl, it get pause time by expectedSleep =
> callable.sleep(pause, tries + 1); And in RegionServerCallable, it get pasue
> time by sleep = ConnectionUtils.getPauseTime(pause, tries + 1). So tries will
> be bumped up twice. And the pasue time is 3 * hbase.client.pause when tries
> is 0.
> RETRY_BACKOFF = {1, 2, 3, 5, 10, 20, 40, 100, 100, 100, 100, 200, 200}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
