[
https://issues.apache.org/jira/browse/HBASE-15708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260850#comment-15260850
]
Dima Spivak commented on HBASE-15708:
-------------------------------------
Two quick things, [~appy]:
- As a best practice,iInstead of directly putting modules into your {{pip}}
call, use {{pip install -r requirements.txt}} (and add a requirements file into
dev-support).
- Break up the {{RUN}} to avoid long lines and be more readable. A common way
to do this would be:
{noformat}
RUN apt-get -y update \
&& apt-get -y install curl python-pip \
&& pip install requests
{noformat}
Otherwise, LGTM.
> Docker for dev-support scripts
> ------------------------------
>
> Key: HBASE-15708
> URL: https://issues.apache.org/jira/browse/HBASE-15708
> Project: HBase
> Issue Type: Bug
> Reporter: Appy
> Assignee: Appy
> Attachments: HBASE-15708-master-v2.patch,
> HBASE-15708-master-v3.patch, HBASE-15708-master-v4.patch,
> HBASE-15708-master.patch
>
>
> Scripts in dev-support are limited in terms of dependencies by what's
> installed on apache machines. Installing new stuff is not easy. It can be
> painful even importing simple python libraries like 'requests'. This jira is
> to add a single docker instance which we can tweak to build the right
> environment for dev-support scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
