[
https://issues.apache.org/jira/browse/HBASE-14954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048652#comment-15048652
]
Hadoop QA commented on HBASE-14954:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12776468/HBASE-14954-v1.patch
against master branch at commit 7bfbb6a3c9af4b0e2853b5ea2580a05bb471211b.
ATTACHMENT ID: 12776468
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not generate new
checkstyle errors.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this
patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:green}+1 zombies{color}. No zombie tests found running at the end of
the build.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16808//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16808//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16808//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16808//console
This message is automatically generated.
> IllegalArgumentException was thrown when doing online configuration change in
> CompactSplitThread
> ------------------------------------------------------------------------------------------------
>
> Key: HBASE-14954
> URL: https://issues.apache.org/jira/browse/HBASE-14954
> Project: HBase
> Issue Type: Bug
> Components: Compaction, regionserver
> Affects Versions: 1.1.2
> Reporter: Victor Xu
> Assignee: Victor Xu
> Attachments: HBASE-14954-v1.patch
>
>
> Online configuration change is a terrific feature for HBase administrators.
> However, when we use this feature to tune compaction thread pool size online,
> it triggered a IllegalArgumentException. The cause is the order of
> setMaximumPoolSize() and setCorePoolSize() of ThreadPoolExecutor: when
> turning parameters bigger, we should setMax first; when turning parameters
> smaller, we need to setCore first. Besides, there is also a copy-code bug in
> merge and split thread pool which I will fix together.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
