[
https://issues.apache.org/jira/browse/GUACAMOLE-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877558#comment-17877558
]
Mike Jumper commented on GUACAMOLE-600:
---------------------------------------
I'm currently seeing SSH connections failing that previously succeeded. The
failure occurs regardless of whether {{timeout}} is left blank or an integer
value. Nothing is jumping out at me as to _why_, but {{git bisect}} reports
that something about the new timeout changes is causing the failure:
{code:none}
1cdda6dd2c8d2fcc48b138298b651241d06a9865 is the first bad commit
commit 1cdda6dd2c8d2fcc48b138298b651241d06a9865 (HEAD)
Author: Virtually Nick <[email protected]>
Date: Thu Feb 16 16:52:23 2023 -0500
GUACAMOLE-600: Add support for setting SSH and SFTP timeouts.
src/common-ssh/common-ssh/ssh.h | 6 +++++-
src/common-ssh/ssh.c | 10 ++++++++--
src/libguac/guacamole/socket-tcp.h | 5 ++++-
src/libguac/guacamole/wol-constants.h | 6 ++++++
src/libguac/guacamole/wol.h | 6 +++++-
src/libguac/socket-tcp.c | 30 ++++++++++++++++++++++++------
src/libguac/wol.c | 6 +++---
src/protocols/rdp/rdp.c | 7 ++++---
src/protocols/rdp/settings.c | 12 ++++++++++++
src/protocols/rdp/settings.h | 11 +++++++++++
src/protocols/ssh/settings.c | 11 +++++++++++
src/protocols/ssh/settings.h | 12 ++++++++++++
src/protocols/ssh/ssh.c | 10 ++++++----
src/protocols/vnc/settings.c | 12 ++++++++++++
src/protocols/vnc/settings.h | 10 ++++++++++
src/protocols/vnc/vnc.c | 7 ++++---
16 files changed, 137 insertions(+), 24 deletions(-)
{code}
> Allow specifying connection timeout
> -----------------------------------
>
> Key: GUACAMOLE-600
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-600
> Project: Guacamole
> Issue Type: New Feature
> Components: Documentation, RDP, SSH, Telnet, VNC
> Reporter: Nick Couchman
> Assignee: Nick Couchman
> Priority: Minor
> Fix For: 1.6.0
>
>
> This came up in a mailing list discussion, specifically related to SSH
> connections, but seems like it would be useful across all of the protocols to
> allow the connection to specify the timeout in making the connection. For
> environments where connections are expected to happen rapidly this can reduce
> delays if something is wrong; for environments that may experience larger
> delays it can avoid errors when the connection is expected to take a longer
> amount of time to establish.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
