[
https://issues.apache.org/jira/browse/GUACAMOLE-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760649#comment-17760649
]
Mike Jumper edited comment on GUACAMOLE-1846 at 8/30/23 10:37 PM:
------------------------------------------------------------------
The previous failure seems to be resolved, but there's now a build failure in
the common convenience library:
{code:none}
...
#8 63.77 make[3]: Entering directory `/build/guacamole-server/src/libguac/tests'
#8 63.77 make[3]: Nothing to be done for `all'.
#8 63.77 make[3]: Leaving directory `/build/guacamole-server/src/libguac/tests'
#8 63.77 make[2]: Leaving directory `/build/guacamole-server/src/libguac'
#8 63.77 Making all in src/common
#8 63.78 make[2]: Entering directory `/build/guacamole-server/src/common'
#8 63.79 Making all in .
#8 63.80 make[3]: Entering directory `/build/guacamole-server/src/common'
#8 63.81 CC libguac_common_la-io.lo
#8 64.00 CC libguac_common_la-blank_cursor.lo
#8 64.24 CC libguac_common_la-clipboard.lo
#8 64.59 CC libguac_common_la-cursor.lo
#8 65.05 CC libguac_common_la-display.lo
#8 65.16 display.c: In function 'guac_common_display_dup':
#8 65.16 display.c:170:18: error: 'client' redeclared as different kind of
symbol
#8 65.16 guac_client* client = user->client;
#8 65.16 ^
#8 65.16 display.c:167:52: note: previous definition of 'client' was here
#8 65.16 guac_common_display* display, guac_client* client,
#8 65.16 ^
#8 65.16 display.c:170:27: error: 'user' undeclared (first use in this function)
#8 65.16 guac_client* client = user->client;
#8 65.16 ^
#8 65.16 display.c:170:27: note: each undeclared identifier is reported only
once for each function it appears in
#8 65.17 make[3]: *** [libguac_common_la-display.lo] Error 1
#8 65.17 make[3]: Leaving directory `/build/guacamole-server/src/common'
#8 65.17 make[2]: *** [all-recursive] Error 1
#8 65.17 make[2]: Leaving directory `/build/guacamole-server/src/common'
#8 65.18 make[1]: *** [all-recursive] Error 1
#8 65.18 make[1]: Leaving directory `/build/guacamole-server'
#8 65.18 make: *** [all] Error 2
#8 ERROR: process "/bin/sh -c /bin/bash -e -x /build/build.sh" did not complete
successfully: exit code: 2
{code}
was (Author: mike.jumper):
The previous failure seems to be resolved, but there's no a build failure
running the unit tests:
{code:none}
...
#8 63.77 make[3]: Entering directory `/build/guacamole-server/src/libguac/tests'
#8 63.77 make[3]: Nothing to be done for `all'.
#8 63.77 make[3]: Leaving directory `/build/guacamole-server/src/libguac/tests'
#8 63.77 make[2]: Leaving directory `/build/guacamole-server/src/libguac'
#8 63.77 Making all in src/common
#8 63.78 make[2]: Entering directory `/build/guacamole-server/src/common'
#8 63.79 Making all in .
#8 63.80 make[3]: Entering directory `/build/guacamole-server/src/common'
#8 63.81 CC libguac_common_la-io.lo
#8 64.00 CC libguac_common_la-blank_cursor.lo
#8 64.24 CC libguac_common_la-clipboard.lo
#8 64.59 CC libguac_common_la-cursor.lo
#8 65.05 CC libguac_common_la-display.lo
#8 65.16 display.c: In function 'guac_common_display_dup':
#8 65.16 display.c:170:18: error: 'client' redeclared as different kind of
symbol
#8 65.16 guac_client* client = user->client;
#8 65.16 ^
#8 65.16 display.c:167:52: note: previous definition of 'client' was here
#8 65.16 guac_common_display* display, guac_client* client,
#8 65.16 ^
#8 65.16 display.c:170:27: error: 'user' undeclared (first use in this function)
#8 65.16 guac_client* client = user->client;
#8 65.16 ^
#8 65.16 display.c:170:27: note: each undeclared identifier is reported only
once for each function it appears in
#8 65.17 make[3]: *** [libguac_common_la-display.lo] Error 1
#8 65.17 make[3]: Leaving directory `/build/guacamole-server/src/common'
#8 65.17 make[2]: *** [all-recursive] Error 1
#8 65.17 make[2]: Leaving directory `/build/guacamole-server/src/common'
#8 65.18 make[1]: *** [all-recursive] Error 1
#8 65.18 make[1]: Leaving directory `/build/guacamole-server'
#8 65.18 make: *** [all] Error 2
#8 ERROR: process "/bin/sh -c /bin/bash -e -x /build/build.sh" did not complete
successfully: exit code: 2
{code}
> Race condition can cause the first user for a connection to miss updates
> ------------------------------------------------------------------------
>
> Key: GUACAMOLE-1846
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1846
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Reporter: James Muehlner
> Priority: Minor
> Fix For: 1.5.4
>
>
> The changes in https://github.com/apache/guacamole-server/pull/39 seem to
> have introduced a potential race condition where the client thread may write
> updates to the broadcast socket before the first user (the owner) is added to
> the user list.
> This change was made nearly 7 years ago, and I never noticed it before
> testing my changes in https://github.com/apache/guacamole-server/pull/454, so
> it's fair to say that it doesn't happen very often. I only see it maybe 10%
> of the time, and only with an RDP connection using the Cygwin build of
> guacamole-server.
> The symptoms are that nothing but a blank screen is rendered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
