Blake Bender created GEODE-9461:
-----------------------------------
Summary: Eliminate use of macros in CLI ExceptionTypes.hpp
Key: GEODE-9461
URL: https://issues.apache.org/jira/browse/GEODE-9461
Project: Geode
Issue Type: Improvement
Components: native client
Reporter: Blake Bender
This kind of thing is an anti-pattern, and needs to be stamped out of the code
base:
{code}
#define _GF_MG_EXCEPTION_TRY2 \
try {
{code}
Other bad macros in this file include _GF_MG_EXCEPTION_CATCH_ALL2,
_GF_MG_EXCEPTION_DEF3, and _GF_MG_EXCEPTION_DEF4. The latter 2 should be
replaced (if possible) by one or two judicious template classes, or written out
longhand because even brute force is better than what we have. Where possible,
code for the various methods should be moved to an implementation file, rather
than left in the header. CLI code in headers has its own special brand of
problems, making it extremely difficult to modify.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
