[
https://issues.apache.org/jira/browse/GEODE-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369043#comment-17369043
]
ASF subversion and git services commented on GEODE-9258:
--------------------------------------------------------
Commit c0ca9ec6b5b75fa3844b31d8c77f72902f2f1bfd in geode's branch
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c0ca9ec ]
GEODE-9258: Move implementations out of NullRedisString and NullRedisSet (#6639)
- Move set and bitOp implementations from NullRedisString to
RedisStringCommandsFunctionExecutor
- Move sunionstore, sdiffstor and sinterstore implementations from
NullRedisSet to RedisSetCommandsFunctionExecutor
Authored-by: Donal Evans <[email protected]>
> Move method implementations out of NullRedis* classes into
> *CommandFunctionExecutors
> ------------------------------------------------------------------------------------
>
> Key: GEODE-9258
> URL: https://issues.apache.org/jira/browse/GEODE-9258
> Project: Geode
> Issue Type: Task
> Components: redis
> Affects Versions: 1.15.0
> Reporter: Donal Evans
> Assignee: Donal Evans
> Priority: Major
> Labels: pull-request-available, redis
> Fix For: 1.15.0
>
>
> {{NullRedisString}} has methods implementing {{bitOp}} and {{set}} which do
> not require an instance of a {{RedisString}} in order to be invoked. These
> methods should be moved to {{RedisStringCommandsFunctionExecutor}}.
> Similarly, {{NullRedisSet}} has the {{sunionstore}}, {{sinterstore}} and
> {{sdiffstore}} methods, which should be moved to
> {{RedisSetCommandsFunctionExecutor}}. Once moved, unit tests should be added
> to verify the methods.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
