[
https://issues.apache.org/jira/browse/GEODE-8949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289287#comment-17289287
]
ASF GitHub Bot commented on GEODE-8949:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #750:
URL: https://github.com/apache/geode-native/pull/750#discussion_r581347170
##########
File path: clicache/integration-test/CacheHelperN.cs
##########
@@ -2143,14 +2147,23 @@ static int ExecuteGfsh(string command)
}
}
- //process.CancelOutputRead();
- //process.CancelOutputRead();
-
Util.Log("ExecuteGfsh: Exited {0}", process.Id);
return process.ExitCode;
}
}
+ public static void CloseAndIgnore(StreamReader streamRead)
+ {
+ try
+ {
+ streamRead.Close();
+ }
+ catch (Exception)
+ {
+ // ignored
Review comment:
No this is to ignore exceptions on closing file handles to sub processes
rather than failing the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create a Continuous Integration Pipeline
> ----------------------------------------
>
> Key: GEODE-8949
> URL: https://issues.apache.org/jira/browse/GEODE-8949
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> This will be our open source CI for publishing to the Apache Software
> Foundation. Two primary tenets are:
> * based on Concourse
> * PRs will trigger the CI pipeline and can't be merged until they pass the CI
> Note: The bulk of this work has been completed in draft [PR
> #716|http://github.com/apache/geode-native/pull/716]. See that PR for further
> details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
