[
https://issues.apache.org/jira/browse/GEODE-8949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285520#comment-17285520
]
ASF GitHub Bot commented on GEODE-8949:
---------------------------------------
moleske commented on pull request #745:
URL: https://github.com/apache/geode-native/pull/745#issuecomment-780147108
Do you have a recommended way of reviewing these changes? Normally I tried
to look at individual commits if there are specific and descriptive commit
messages, but there's 30 commits to go through. There are also changes to
clang tidy and format (I think moving from 6 to 11?) in addition to adding a
pipeline (and some other things since I see changes to c# files, which I assume
is fixing the compilation problem I've seen on VS2019.) While I'm a fan of an
up to date clang, I don't know how that is suppose to factor in this change.
In the shadow pipeline I've been running, I didn't have to make those changes
so surprised they are in here. Definitely will need time to look at all these
changes (seems like large deletes of packer things happened also)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create a Continuous Integration Pipeline
> ----------------------------------------
>
> Key: GEODE-8949
> URL: https://issues.apache.org/jira/browse/GEODE-8949
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> This will be our open source CI for publishing to the Apache Software
> Foundation. Two primary tenets are:
> * based on Concourse
> * PRs will trigger the CI pipeline and can't be merged until they pass the CI
> Note: The bulk of this work has been completed in draft [PR
> #716|http://github.com/apache/geode-native/pull/716]. See that PR for further
> details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
