[
https://issues.apache.org/jira/browse/GEODE-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285518#comment-17285518
]
ASF GitHub Bot commented on GEODE-8947:
---------------------------------------
bschuchardt commented on a change in pull request #6038:
URL: https://github.com/apache/geode/pull/6038#discussion_r577169369
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tx/RemoteOperationMessage.java
##########
@@ -177,7 +179,28 @@ public void process(final ClusterDistributionManager dm) {
sendReply(getSender(), this.processorId, dm, replyException, null, 0);
return;
}
- dm.getExecutors().getWaitingThreadPool().execute(() ->
doRemoteOperation(dm, cache));
+
+ String conserveSockets = getConserveSocketsSetting(dm);
+ if (conserveSockets != null && conserveSockets.equals("false")) {
+ // reply inline for CONSERVE_SOCKETS == false case.
+ doRemoteOperation(dm, cache);
+ return;
+ }
+
+ if (isTransactional()) {
+ dm.getExecutors().getWaitingThreadPool().execute(() ->
doRemoteOperation(dm, cache));
+ } else {
+ // reply inline for non-transactional case.
+ doRemoteOperation(dm, cache);
+ }
+ }
+
+ String getConserveSocketsSetting(ClusterDistributionManager dm) {
+ return dm.getSystem().getProperties().getProperty(CONSERVE_SOCKETS);
Review comment:
I think what you want to know here is whether the message is going to be
sent on a thread-owned Socket or a shared Socket. To determine that you need
to use InternalDistributedSystem.threadOwnsResources(), not the
conserve-sockets setting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Performance degradations due to GEODE-8930
> ------------------------------------------
>
> Key: GEODE-8947
> URL: https://issues.apache.org/jira/browse/GEODE-8947
> Project: Geode
> Issue Type: Bug
> Affects Versions: 1.12.1, 1.13.2, 1.14.0, 1.15.0
> Reporter: Donal Evans
> Assignee: Eric Shu
> Priority: Major
> Labels: pull-request-available
>
> Following the changes introduced by GEODE-8930, performance degradations were
> seen in situations involving P2P puts with replicated regions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
