[
https://issues.apache.org/jira/browse/GEODE-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187852#comment-17187852
]
ASF GitHub Bot commented on GEODE-8462:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5483:
URL: https://github.com/apache/geode/pull/5483#discussion_r480247313
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
##########
@@ -99,7 +99,7 @@ public NettyRedisServer(Supplier<DistributionConfig>
configSupplier,
throw new IllegalArgumentException("Redis port cannot be less than 0");
}
this.bindAddress = getBindAddress(requestedAddress);
- selectorGroup = createEventLoopGroup("Selector", false, 1);
+ selectorGroup = createEventLoopGroup("Selector", true, 1);
Review comment:
Was this non-daemon thread still hanging around and that caused
problems? It might be okay for this to be daemon threads (that allows the JVM
to exit without shutting down the redis server) but we should probably still do
some cleanup of these groups before we throw the ManagementException. We should
try calling the "stop" method before throwing the ManagementException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> GeodeRedisServer should fail with msg if redis-port and redis-bind-address
> are in use
> -------------------------------------------------------------------------------------
>
> Key: GEODE-8462
> URL: https://issues.apache.org/jira/browse/GEODE-8462
> Project: Geode
> Issue Type: Bug
> Reporter: John Hutchison
> Priority: Minor
> Labels: pull-request-available, redis
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
