nhuantho commented on PR #2477: URL: https://github.com/apache/fluss/pull/2477#issuecomment-3980623765
> @MehulBatra, I agree with extracting common test methods. > > I also share your concern regarding increased test execution time and support reusing the Flink mini-cluster as an optimization. Let's track this improvement in a follow-up PR. However, we cannot simply extend `AbstractTestBase` in this case, as we need to override specific checkpoint configurations. Hi @wuchong, @MehulBatra I have a question, Can we move `MiniClusterWithClientResource` to beforeAll, instead of beforeEach. From my side, it can reduce time to creating MiniCluster. I tested with: * First * Create MiniCluster in beforeEach <img width="641" height="552" alt="image" src="https://github.com/user-attachments/assets/d76ccf44-8dd0-496a-b869-dc9dbce593e2"; /> * Create MiniCluster in beforeAll <img width="628" height="278" alt="image (4)" src="https://github.com/user-attachments/assets/91a358f7-e682-4a42-8ef3-769925664f1d"; /> * Second * Create MiniCluster in beforeEach <img width="1164" height="278" alt="image" src="https://github.com/user-attachments/assets/fb879166-bc48-47fd-89e5-b70a61fe85d7"; /> * Create MiniCluster in beforeAll <img width="1184" height="287" alt="image" src="https://github.com/user-attachments/assets/6036a1c8-b844-4141-8f3d-ce303df02a6a"; /> * If it is correct, I can create a pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
