leekeiabstraction commented on code in PR #360:
URL: https://github.com/apache/fluss-rust/pull/360#discussion_r2843096222
##########
bindings/cpp/src/lib.rs:
##########
@@ -607,12 +608,17 @@ fn err_from_core_error(e: &fcore::error::Error) ->
ffi::FfiResult {
// Connection implementation
fn new_connection(config: &ffi::FfiConfig) -> Result<*mut Connection, String> {
+ let assigner_type = match config.writer_bucket_no_key_assigner.as_str() {
+ "round_robin" => fluss::config::NoKeyAssigner::RoundRobin,
+ _ => fluss::config::NoKeyAssigner::Sticky,
Review Comment:
Does this silently fallback to sticky? What if user has a typo in round
robin? Also curious about how other configuration behave on illegal values
(both currently in rust and Java)
I think that left shift and fail fast is a better user experience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
