charlesdong1991 commented on code in PR #363:
URL: https://github.com/apache/fluss-rust/pull/363#discussion_r2838105286
##########
website/docs/user-guide/rust/api-reference.md:
##########
@@ -71,6 +71,22 @@ Complete API reference for the Fluss Rust client.
|--------------------------------------------------------------------------------------------|------------------------------|
| `async fn get_latest_lake_snapshot(&self, table_path: &TablePath) ->
Result<LakeSnapshot>` | Get the latest lake snapshot |
+### Cluster Operations
+
+| Method | Description
|
+|---------------------------------------------------------------|-----------------------------------------------------|
+| `async fn get_server_nodes(&self) -> Result<Vec<ServerNode>>` | Get all
alive server nodes (coordinator + tablets) |
+
+## `ServerNode`
+
+| Method | Description
|
+|-----------------------------------|------------------------------------------------------|
+| `fn id(&self) -> i32` | Server node ID
|
+| `fn host(&self) -> &str` | Hostname of the server
|
+| `fn port(&self) -> u32` | Port number
|
+| `fn server_type(&self) -> &ServerType` | Server type (`CoordinatorServer` or
`TabletServer`) |
+| `fn uid(&self) -> String` | Unique identifier (e.g. `"cs-0"`,
`"ts-1"`) |
Review Comment:
> the actual implementation returns &String (which should ideally be &str).
Copilot is right here, ideally should be `&str`, but this PR didn't touch
the definition of `&String` (aka `fn uid(&self) -> &String` part) , so should I
include the change in current PR or you prefer to have it in a separate PR?
@luoyuxia
should be very small code change though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
