jbonofre commented on code in PR #2703: URL: https://github.com/apache/fluss/pull/2703#discussion_r2836193547
########## LICENSE-bin: ########## @@ -0,0 +1,1173 @@ + Apache License Review Comment: It's pretty hard to have all auto-generated (especially when you shade a dependency which has itself a shade dependency). I'm having some scripts to assist me, but I do most the checks "manually". The `LICENSE` should contain all code and dependencies you bundle in the artifact, with the type of license and copyright. In the case of BSD or MIT license, the license content should be inline our own `LICENSE`. The `NOTICE` file should be as simple as possible. It should contain only the relevant information of the `NOTICE` file for the Apache license dependencies. For instance, Netty is Apache licensed dependency, so as Netty has a `NOTICE`, the Netty `NOTICE` content should be in our `NOTICE` (the relevant information). If the Apache licensed dependency doesn't have `NOTICE`, nothing is required. In the case of ASF dependencies (like Apache Flink), it's not strictly required to include `NOTICE` because it's covered by `This product includes software developed at The Apache Software Foundation (http://www.apache.org/)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
