Copilot commented on code in PR #2702:
URL: https://github.com/apache/fluss/pull/2702#discussion_r2835766524


##########
fluss-lake/fluss-lake-iceberg/src/main/resources/META-INF/NOTICE:
##########
@@ -41,15 +41,3 @@ This project bundles the following dependencies under the 
Apache Software Licens
 - org.jetbrains:annotations:17.0.0
 - commons-pool:commons-pool:1.6
 - com.google.errorprone:error_prone_annotations:2.10.0

Review Comment:
   `fluss-lake-iceberg` still ships `META-INF/NOTICE`, but this module does not 
have a corresponding `META-INF/LICENSE` (and no `META-INF/licenses/` 
directory). Since this hunk removes the previously listed non-Apache 
dependencies from the NOTICE, the resulting jar will have no place to carry the 
required license text / third-party license references. Please add a 
`src/main/resources/META-INF/LICENSE` (and any needed `META-INF/licenses/*` 
files) for this module, consistent with the other jars updated in this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to