leekeiabstraction commented on code in PR #349: URL: https://github.com/apache/fluss-rust/pull/349#discussion_r2819117075
########## website/docs/user-guide/cpp/data-types.md: ########## @@ -58,6 +60,7 @@ Field values are read through `RowView` (from scan results) and `LookupResult` ( :::warning Lifetime `RowView` borrows from `ScanRecords`. It must not outlive the `ScanRecords` that produced it (similar to `std::string_view` borrowing from `std::string`). +::: Review Comment: Hmm, moving this actually makes the code part seem like it's not part of the warning. I do appreciate however that the code part enclosed within warning looks a bit ugly. I have no good suggestion though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
